7 studies on the effectiveness of peer and teacher feedback have been critically reviewed in this paper,some problems being perceived either in the research design or their research findings.Based on the detected problems,I put forward some suggestions for the future study and then draw some pedagogical implications.